Replace serverlist with Avalonia.DataGrid control, fixing lag and other long-standing issues #232
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Aesthetically I definitely prefer having the separators between columns. Also the "go to servers tab" button being full-width is weird. |
|
I've added column separators, and I've fixed the go to servers button. One very minor regression: the go to servers button is now under the scroll container as opposed to inside the scroll container, but because the scroll container is inside the DataGrid it would be quite a pain in the ass to put it inisde (I really wish Avalonia had better documentation for templating). I think it's fine like this. I've also added column sorting :> |
|
You can't a server info entry after opening it. Also removal of the arrow indicating it's expandable is bad UX. |
2 participants
This PR makes it so that the server list is an actual proper grid, instead of the hacky stuff we've had up until now. This fixes major amounts of lag (when changing filters, or just switching tabs when no filters are applied). It also theoretically makes it possible in the future
to add proper sorting(sorting works now :3), and hiding specific columns.Before (I'm trying to switch tabs and toggle filters as fast as possible):
before.mp4
After (outdated, has column separators and sorting now):
after.mp4
I wish I could provide cleaner separate commits but I've been working on this off and on since February so it got too messy